-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing inkscape package from the minimal-notebook #1765
Conversation
for more information, see https://pre-commit.ci
@Bidek56 For the
or
depending on how many different formats the notebook file ( |
Any reason to use |
I do not know much about R but based on this article we can set the plot_mimetypes right in the code. |
Setting Setting |
I am only using ℹ️ Every format specified is stored in the notebook file ( |
Why set these at all? Why not add a documentation line showing users how to add this line to their notebook: |
Removing It must work with the default settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I don't like copy-pasting the profile file. I suggest we add it to
minimal-notebook
.
Because we change this behaviour for every user ofminimal-notebook
or image that depends on it, it makes more sense. -
Could we add a test that image rendering works properly for both Python and R notebooks?
Co-authored-by: Ayaz Salikhov <[email protected]>
Are you saying that you are OK with adding |
This code works without
since by default it seems to be set to |
Yes, I'm ok with both options. I prefer
Unfortunately, I can't help with the example here. |
Co-authored-by: Ayaz Salikhov <[email protected]>
The default for Tested with library(ggplot2)
ggplot(airquality, aes(Temp, Ozone)) +
geom_point() +
geom_smooth(method = "loess"
) ℹ️ Image size: 840 x 840 pixels, Image DPI: 120 pixels/inch getOption("jupyter.plot_mimetypes")
getOption("jupyter.plot_scale")
Notebook file: No |
Hope this helps in understanding the current And as mentioned before: |
What's the status of this PR? |
I am trying to create tests as per your request but unfortunately I do not know enough about it. |
for more information, see https://pre-commit.ci
@benz0li @mathbunnyru I have added basic R tests, unfortunately I do not know enough about |
Could you please remove code duplication as well? |
Which code duplication? In the tests? |
The test file, |
They are used in different stacks, how would you suggest we re-use them across multiple stacks? |
As we discussed above, for the config file, let's put it to minimal-notebook. |
The |
Sorry for not being clear. I propose the following:
|
Removing duplicate R test code
for more information, see https://pre-commit.ci
Co-authored-by: Ayaz Salikhov <[email protected]>
Co-authored-by: Ayaz Salikhov <[email protected]>
for more information, see https://pre-commit.ci
With the current changes, Either reduce ℹ️ Every format specified is stored in the notebook file ( |
Describe your changes
Removing inkscape package from the minimal-notebook as suggested by @benz0li in this issue.
Checklist (especially for first-time contributors)